Skip to content

Out-of-place triu/tril for Symmetric in each branch #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Out-of-place triu/tril for Symmetric in each branch #1318

wants to merge 6 commits into from

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Apr 27, 2025

In tril/triu for Symmetric/Hermitian, we should use the out-of-place variants in each branch, unless we're sure that the array may be mutated. Currently, this is only for StridedArrays, in which case we may perform some of the operations in-place.

Fixes issues like

julia> S = @SMatrix [1 2; 3 4]
2×2 SMatrix{2, 2, Int64, 4} with indices SOneTo(2)×SOneTo(2):
 1  2
 3  4

julia> H = Hermitian(S)
2×2 Hermitian{Int64, SMatrix{2, 2, Int64, 4}} with indices SOneTo(2)×SOneTo(2):
 1  2
 2  4

julia> triu(H,-1)
ERROR: setindex!(::SMatrix{2, 2, Int64, 4}, value, ::Int) is not defined.
 Hint: Use `MArray` or `SizedArray` to create a mutable static array

After this PR, this operation would work:

julia> triu(H,-1)
2×2 MMatrix{2, 2, Int64, 4} with indices SOneTo(2)×SOneTo(2):
 1  2
 2  4

@codecov
Copy link

codecov bot commented Apr 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.81%. Comparing base (39ee3af) to head (ae9206e).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1318   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          34       34           
  Lines       15715    15719    +4     
=======================================
+ Hits        14743    14747    +4     
  Misses        972      972

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub force-pushed the jishnub/triul_maybe_inplace branch from 306143a to d1f2c7c Compare May 11, 2025 13:00
@jishnub jishnub force-pushed the jishnub/triul_maybe_inplace branch from d1f2c7c to ae9206e Compare June 2, 2025 11:29
@jishnub jishnub force-pushed the jishnub/triul_maybe_inplace branch from ae9206e to 68b4ace Compare June 16, 2025 08:40
dkarrasch
dkarrasch reviewed Sep 20, 2025
View reviewed changes
src/adjtrans.jl Outdated
Comment on lines 394 to 398
AbstractMatrix{T}(A::AdjOrTransAbsVec) where {T} = wrapperop(A)(AbstractVector{T}(A.parent))
AbstractMatrix{T}(A::AdjOrTransAbsVec) where {T} = wrappertype(A)(AbstractVector{T}(A.parent))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there cases where the former doesn't do what we want?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any immediately. This was an overly conservative change that may not be necessary in practice.

@jishnub jishnub force-pushed the jishnub/triul_maybe_inplace branch from bbcfa7d to 7d34ec6 Compare September 22, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jishnub @dkarrasch